-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New approach to peer config #17
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gvbalaji, henderiw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@s3wong could you have a look at this? |
I still have question on how do we get to the N3 IP address from SMF controller? So SMF controller is supposed to get a list of PeerConfig --- each of them representing a UPF? And the attachment is N4, so the Peers[i].IPv4 will contain to N4 IP address How do we get to the N3 on this peer UPF? I noticed you added Labels and NetworkInstance, not sure if either is useful. What is your plan on how we (operator team) can use these fields? |
@s3wong Lets assume we have 2 upf(s) : 1 on edge1 and 1 on edge2. The smf package is augmented with the UPF with the additional IPAllocation objects:
UPF-edge1: this info should be available in the topology + fanout -> sites info you get from topology, network-instance from top and kind you could get from interface (I can provide the logic for that as this is also used in if-fn). IPAllocation query for UPF on edge1 apiVersion: ipam.alloc.nephio.org/v1alpha1 apiVersion: ipam.alloc.nephio.org/v1alpha1 Same for UPF on edge2 apiVersion: ipam.alloc.nephio.org/v1alpha1 apiVersion: ipam.alloc.nephio.org/v1alpha1 During specialization we use this information to resolve the IP(s) that were allocated to these UPFs. The nf-deploy function add this information in the SMFdeployment. peers:
|
To understand the (free5gc) SMF config for this, the layout is:
So, logically, we group by peer NF, and identify the connected point (N4 IP on the connected UPF in this case), and N3 and N9 IP addresses under that one UPF.
|
in specialisation we do not get topology, since a package it per NF. What we agreed is we get a request for an IP. So what is proposed here is a list with the info. The receiving end just have to go through it to provide the structure. I believe not everyone need this structure and seems specific to the free5gc. I don't want to build just for free5gc. So here we just need to run through the list and get the info but the structure how you consume it is the job of the receiver |
Make peer config independent of the network instance as it might be that the peer is not configured on the NF.
In this proposal the peerconfig is a list of peers: