agent,plugin: Remove metrics from AgentRequests #1145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No changes to the coverage.
HTML Report |
This is a requirement for the stateless scheduler work -- otherwise we need to continue updating every pod regularly, which may overload etcd.
sharnoff
force-pushed
the
sharnoff/rm-AgentRequests.metrics
branch
from
e385e40 to
095ab34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAICT is a requirement for #995 — otherwise we need to continue updating every pod regularly, which may overload etcd. In the longer term, we may wish to have the scheduler fetch its own metrics, e.g. via the metrics API 1 2. In the meantime, this PR implements a metric-less approach for prioritizing live migrating by preferring to migrate the older pods on a node, with the intent being that this will naturally be somewhat fair so that individual VMs are not migrated too much.
Notes for review:
This PR currently builds upon #1143 and #1144. Only the final commit in this PR (e385e40) is the actual intended change here.Also, I think the other PRs are probably more clearly worthwhile than this one— I'm happy to leave this as a draft until I have something building on it.