chore(neon): Improve ValueInternal safety #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValueInternal::is_typeof and ValueInternal::downcast accept raw `Env`, but can trivially accept `Cx` instead.
kjvalencik
commented
Oct 11, 2024
| @@ -31,13 +34,13 @@ pub(crate) unsafe fn prepare_call<'a, 'b, C: Context<'a>>( | |||
| pub trait ValueInternal: TransparentNoCopyWrapper + 'static { | |||
There was a problem hiding this comment.
ValueInternal::from_local could accept safe wrappers, but it would need to remain unsafe since it doesn't perform type checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValueInternal::is_typeofandValueInternal::downcastaccept rawEnv, but can trivially acceptCxinstead.This will allow for global type wrappers (e.g., #1080) that can type check without any unsafe code.