change(neon): Change TryIntoJs and TryFromJs accept Cx instead of being generic over Context #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng generic over Context Being generic over `Context` offers no benefits over `Cx`. It is simpler to remove a generic argument. * Every `Context` derefs to `Cx` * `Cx` implements `Context` * Reduces code bloat from monomorphization
dherman
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
This looks great!
I noticed a handful of places in the API docs where there are examples of generic functions that take C: Context<'cx> (1, 2, 3). Should we change those to take a Cx now as well?
I also filed an issue for the website to change the guides to use the new Cx type once it gets published.
| fn try_neon_export_return<C>(self, cx: &mut C) -> JsResult<'cx, JsValue> | ||
| where | ||
| C: Context<'cx>; | ||
| fn try_neon_export_return(self, cx: &mut Cx<'cx>) -> JsResult<'cx, JsValue>; |
There was a problem hiding this comment.
This is such a quality of life improvement. Wow.
|
@dherman Great catch! Those are the only examples I saw that still unnecessarily used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being generic over
Contextoffers no benefits overCx. It is simpler to remove a generic argument.Contextderefs toCxCximplementsContextWe should double check that there's no other new APIs introduced in the pre-release that could benefit from this change. Unfortunately, we can't change existing APIs without a breaking change.