Add a display name extension to KeyMapping
#1826
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
getDisplayName
method toIKeyMappingExtension
, allowing custom key mapping implementations to show users a name in the keybindings GUI that is not a translatable component of their ID.This method can be used, for instance, by generated key mappings that are not statically known at build-time and therefore have no translations for their names. I am working on a mod which allows users to create their own key bundles on-demand to disambiguate keymappings and I need to display the name they gave to the bundle in the bindings UI instead of an untranslated translation key.