-
-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inlayHint): add inlayHint.position
configuration
#5060
Conversation
Thank you for your PR! Please change the configuration to |
12dfe6c
to
4413163
Compare
afterText
option to move hints after textinlayHint.position
configuration
inlayHint.position
configurationinlayHint.position
configuration
4413163
to
4a59637
Compare
Switched to use |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5060 +/- ##
==========================================
- Coverage 98.52% 98.49% -0.03%
==========================================
Files 273 273
Lines 26081 26084 +3
Branches 5389 5390 +1
==========================================
- Hits 25696 25692 -4
- Misses 226 232 +6
- Partials 159 160 +1 ☔ View full report in Codecov by Sentry. |
Hmm, can the test failure on nightly be related to this PR, or is it flaky? :o |
Thanks! 🥳 |
I know this is a lot to ask but we used to be able to add an icon and color of the inlay hints in our cocconfig. Would it be possible to support those features as well? |
You can configure the color by changing the Icon I dunno. |
I should probably make this an issue, but I'm not sure we want to support this. In either case before (a long time ago), we used to have the following options.
|
@SeniorMars the separator configuration has been removed and has no plan to add back, because language server will add separator like |
@all-contributors please add @de-vri-es for code. |
I've put up a pull request to add @de-vri-es! 🎉 |
This PR adds an option to move all inlay hints to after the original text.
Personally, I find hints inside the source code very distracting. And they make the code look much wider than it really is, which I personally do not like.
This option allows to restore the old behavior where all hints were displayed at the end of a line.