Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for translanting job-owner of kickstart #301

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

skycastlelily
Copy link
Contributor

No description provided.

@dav-pascual dav-pascual self-requested a review November 4, 2024 16:56
@dav-pascual
Copy link
Member

dav-pascual commented Nov 4, 2024

This translates beaker-job-owner from tmt (listed here https://tmt.readthedocs.io/en/1.37.0/plugins/provision.html) to beaker param right? Could you confirm as a I did not find the param in beaker documentation

@dav-pascual
Copy link
Member

Let me also run a simple integration test for this. Have you tried to run this branch with tmt/TF?

@skycastlelily
Copy link
Contributor Author

skycastlelily commented Nov 5, 2024

Could you confirm as a I did not find the param in beaker documentation

https://beaker-project.org/docs/man/bkr.html(search job-owner)

Have you tried to run this branch with tmt/TF?

Yes,every time before I submit a mr,I will test it first:)

Copy link
Member

@dav-pascual dav-pascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dav-pascual dav-pascual merged commit 64a84db into neoave:main Nov 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants