Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data exception codes. Part 1. #186

Merged
merged 13 commits into from
Oct 17, 2024
Merged

Add data exception codes. Part 1. #186

merged 13 commits into from
Oct 17, 2024

Conversation

NataliaIvakina
Copy link
Collaborator

No description provided.

NataliaIvakina
NataliaIvakina commented Oct 10, 2024
View reviewed changes
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
@NataliaIvakina NataliaIvakina requested a review from Lojjs October 10, 2024 12:35
NataliaIvakina
NataliaIvakina commented Oct 15, 2024
View reviewed changes
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Show resolved Hide resolved
Lojjs
Lojjs requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the list parameter question, I only found two discrepancies compared to the code, both which was because we developers failed to update the spreadsheet

modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
Lojjs
Lojjs reviewed Oct 16, 2024
View reviewed changes
modules/ROOT/pages/errors/gql-errors.adoc Outdated
Status description:: error: data exception - invalid import value. Importing entity values to a graph with a USE clause is not supported. Attempted to import { $expr } to { $graph }.

=== 22N17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have deleted 22N17 from the code and it also is marked as 'DELETE' in the spreadsheet. I think it was a copy of another code or wrong in some other way. Maybe you can remind me @anderson4j ? Anyway, we should probably exclude this one from docs too.

NataliaIvakina
NataliaIvakina commented Oct 17, 2024
View reviewed changes
Copy link
Collaborator Author

@NataliaIvakina NataliaIvakina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lojjs, could you take one more look?

modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

Lojjs
Lojjs approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now

@NataliaIvakina NataliaIvakina merged commit 2c2494a into neo4j:gqlstatus-errors Oct 17, 2024
5 checks passed
@NataliaIvakina NataliaIvakina deleted the data-exception-error-codes branch October 17, 2024 11:18
renetapopova pushed a commit that referenced this pull request Oct 31, 2024
@NataliaIvakina @Lojjs @renetapopova
Add data exception codes. Part 1. (#186)
0c61ec7 
Co-authored-by: Louise Berglund <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renetapopova renetapopova renetapopova left review comments

@Lojjs Lojjs Lojjs approved these changes

Assignees
No one assigned
Labels
5.26 gqlstatus-errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NataliaIvakina @neo-technology-commit-status-publisher @Lojjs @renetapopova