Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New GQL statuses #164

Closed

Conversation

NataliaIvakina
Copy link
Collaborator

No description provided.

Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a good start! I left some feedback on various things which could be improved

modules/ROOT/pages/notifications/gqlstatus-info-codes.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/gqlstatus-info-codes.adoc Outdated Show resolved Hide resolved
| 02000
| No data
|
| Successful completion with an empty result
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially we could clarify that this means 'no result rows' (in contrast to 'no result columns' for 00001). But on the other hand, 'empty result' is an established concept which we use elsewhere in docs. I leave it up to you to decide

modules/ROOT/pages/notifications/gqlstatus-info-codes.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/gqlstatus-info-codes.adoc Outdated Show resolved Hide resolved

link:https://neo4j.com/docs/cypher-manual/current/planning-and-tuning/[`EXPLAIN` queries] always give `OMITTED RESULT`.

Classification, severity, position, and status parameters are not meaningful for these GQL statuses, so they are not included in the diagnostic record but the corresponding getter methods on server and driver side will be poly-filled with the default values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drivers treat those values as absence and each driver follow a slightly different. Some made those values optional, others use a UNKNOWN classification/category and empty position, which is more appropriated for the language and driver api.

@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.


Classification, severity, position, and status parameters are not meaningful for these GQL statuses, so they are not included in the diagnostic record but the corresponding getter methods on server and driver side will be poly-filled with the default values.

These statuses are filled in by the server unless the server is too old to be aware of GQL-status objects (the case described in **Compatibility issues**), then it will be filled by the driver.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to link this paragraph to the place where we'll talk about the compatibility between old server and new drivers.

@renetapopova
Copy link
Collaborator

Replaced by #162

@NataliaIvakina NataliaIvakina deleted the new-gql-statuses branch October 16, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants