-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New GQL statuses #164
New GQL statuses #164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like a good start! I left some feedback on various things which could be improved
| 02000 | ||
| No data | ||
| | ||
| Successful completion with an empty result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially we could clarify that this means 'no result rows' (in contrast to 'no result columns' for 00001). But on the other hand, 'empty result' is an established concept which we use elsewhere in docs. I leave it up to you to decide
|
||
link:https://neo4j.com/docs/cypher-manual/current/planning-and-tuning/[`EXPLAIN` queries] always give `OMITTED RESULT`. | ||
|
||
Classification, severity, position, and status parameters are not meaningful for these GQL statuses, so they are not included in the diagnostic record but the corresponding getter methods on server and driver side will be poly-filled with the default values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drivers treat those values as absence and each driver follow a slightly different. Some made those values optional, others use a UNKNOWN
classification/category and empty position, which is more appropriated for the language and driver api.
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
|
||
Classification, severity, position, and status parameters are not meaningful for these GQL statuses, so they are not included in the diagnostic record but the corresponding getter methods on server and driver side will be poly-filled with the default values. | ||
|
||
These statuses are filled in by the server unless the server is too old to be aware of GQL-status objects (the case described in **Compatibility issues**), then it will be filled by the driver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to link this paragraph to the place where we'll talk about the compatibility between old server and new drivers.
Replaced by #162 |
No description provided.