Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GQL status to the DEPRECATION category #153

Merged

Conversation

NataliaIvakina
Copy link
Collaborator

No description provided.

Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two of them looks wrong to me, otherwise great work!

|GQLSTATUS code
m|01N03
|StatusDescription
a|warn: procedure result column deprecated. `$field` returned by procedure `$proc` is deprecated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one might change a bit because we realised it was misleading, but we can merge it like this now and I added to https://trello.com/c/9odnxtyY/252-potential-bug-with-deprecated-procedure-fields to verify that documentation is correct once it has been sorted out (@anderson4j FYI)

modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
@Lojjs Lojjs self-assigned this Jul 1, 2024
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a question for @Lojjs. The rest of my suggestions I'll push directly into the PR.

modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
@renetapopova renetapopova requested a review from Lojjs July 4, 2024 10:35
@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova renetapopova merged commit fe889d2 into neo4j:gql-notifications Jul 5, 2024
5 checks passed
@NataliaIvakina NataliaIvakina deleted the gql-statuses-deprecation branch October 16, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants