Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GQL status to the UNRECOGNIZED category #151

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Add GQL status to the UNRECOGNIZED category #151

merged 3 commits into from
Jun 28, 2024

Conversation

NataliaIvakina
Copy link
Collaborator

No description provided.

@NataliaIvakina NataliaIvakina requested a review from Lojjs June 26, 2024 06:45
@renetapopova renetapopova self-requested a review June 27, 2024 10:08
Lojjs
Lojjs reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if you include the two parameter name changes you have suggested yourself.

@Lojjs Lojjs self-assigned this Jun 28, 2024
renetapopova
renetapopova reviewed Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @NataliaIvakina! I added some suggestions to avoid using Present Perfect and past tenses. Please feel free to improve them or ignore them.

modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
@NataliaIvakina
Copy link
Collaborator Author

Thanks, @NataliaIvakina! I added some suggestions to avoid using Present Perfect and past tenses. Please feel free to improve them or ignore them.

Good suggestions! Thank you

@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@NataliaIvakina NataliaIvakina merged commit 9973d2a into neo4j:gql-notifications Jun 28, 2024
5 checks passed
@NataliaIvakina NataliaIvakina deleted the new-gql-status-unrecognized branch June 28, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renetapopova renetapopova renetapopova left review comments

@Lojjs Lojjs Lojjs approved these changes

Assignees

@Lojjs Lojjs

Labels
gqlstatus-notifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NataliaIvakina @neo-technology-commit-status-publisher @Lojjs @renetapopova