Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GQL info for CartesianProduct, UnboundedVariableLengthPattern, and ExhaustiveShortestPath #146

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Add GQL info for CartesianProduct, UnboundedVariableLengthPattern, and ExhaustiveShortestPath #146

merged 5 commits into from
Jun 20, 2024

Conversation

renetapopova
Copy link
Collaborator

No description provided.

@renetapopova renetapopova requested a review from Lojjs June 14, 2024 16:46
Lojjs
Lojjs requested changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good over all, just two smaller remarks

modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
@NataliaIvakina NataliaIvakina self-assigned this Jun 18, 2024
bigmontz
bigmontz approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔔

(Just have to double check the point @Lojjs bring)

@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

Lojjs
Lojjs approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. If we want to change the tab names, we can do it for all of them later

@NataliaIvakina NataliaIvakina merged commit 91076f0 into neo4j:gql-notifications Jun 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NataliaIvakina NataliaIvakina NataliaIvakina left review comments

@Lojjs Lojjs Lojjs approved these changes

@bigmontz bigmontz bigmontz approved these changes

Assignees

@NataliaIvakina NataliaIvakina

Labels
gqlstatus-notifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@renetapopova @neo-technology-commit-status-publisher @bigmontz @Lojjs @NataliaIvakina