Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version selector bugs #255

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix version selector bugs #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/js/50-cheat-sheet-toggle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,14 @@ const prodMatrix = {

// get the default product from optionMap
const defaultProdArray = optionMap.find((prod) => prod.default === 'true')
const defaultProd = defaultProdArray ? defaultProdArray.value : optionMap[0].value

// display for 'all' products unless a differnt value is specified via attributes in source
let defaultProd
if (defaultProdArray && optionMap) {
defaultProd = defaultProdArray ? defaultProdArray.value : optionMap[0].value
} else {
defaultProd = 'all'
}
const defaultClasses = ['exampleblock', 'sect2', 'sect1']

document.addEventListener('DOMContentLoaded', function () {
Expand Down
2 changes: 1 addition & 1 deletion src/partials/nav-selectors.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

<select data-current="{{@root.page.version}}" class="version-selector dropdown-styles">
{{#each page.versions}}
{{#unless (or this.prerelease (and (eq this.version @root.page.version) (eq @root.page.attributes.theme 'cheat-sheet') ))}}
{{#unless this.prerelease}}
<option
data-version="{{this.displayVersion}}"
value="{{{relativize this.url}}}"
Expand Down