Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beta-until label #254

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Add beta-until label #254

merged 5 commits into from
Aug 22, 2024

Conversation

recrwplay
Copy link
Collaborator

For new and deprectaed labels it is already possible to include a version number. Although we have a generic beta label that can be used to display just the text Beta, there is no way to display a version with the text, for example Beta until 5.12.

This PR adds a new label--beta-until-<version> role to be used for beta labels where a version number is also required.

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for neo4j-docs-ui ready!

Name Link
🔨 Latest commit 56a21a9
🔍 Latest deploy log https://app.netlify.com/sites/neo4j-docs-ui/deploys/66c739ee3caf1d0009a01690
😎 Deploy Preview https://deploy-preview-254--neo4j-docs-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

recrwplay and others added 2 commits August 22, 2024 14:11
Recent updates in the version selector, and previous changes that were
specific to the cheat sheet, meant the version of the cheat that is
being displayed was excluded from the version selector.

This PR fixes that and a bug in the code for defining the default
product to display.
@recrwplay recrwplay merged commit f4dec1d into master Aug 22, 2024
5 checks passed
@recrwplay recrwplay mentioned this pull request Aug 29, 2024
recrwplay added a commit that referenced this pull request Aug 29, 2024
Fixes a bug where `role=label--deprecated` was not being displayed

eg
https://neo4j.com/docs/cypher-manual/current/subqueries/call-subquery/#importing-with

Found a bug introduced in #254 that was treating deprecated as a role
that required a version to be specified. Deprecated can be used with or
without a version number.
@recrwplay recrwplay deleted the beta-label branch November 27, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant