Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove first dropdown entry #245

Merged

Conversation

rsill-neo4j
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for neo4j-docs-ui ready!

Name Link
🔨 Latest commit 1474dfd
🔍 Latest deploy log https://app.netlify.com/sites/neo4j-docs-ui/deploys/669e4ad7ca04b6000864f244
😎 Deploy Preview https://deploy-preview-245--neo4j-docs-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rsill-neo4j rsill-neo4j requested a review from recrwplay July 22, 2024 13:47
Copy link
Collaborator

@recrwplay recrwplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified by local build of docsets.

src/partials/nav-explore.hbs Show resolved Hide resolved
@recrwplay
Copy link
Collaborator

The reason this PR is needed is that we have changed the way the component title and version are displayed, by separating the two.

Previously the selector included the component name and version name for the page being viewed, and just the version name for all the other versions of the same page.

Now, the component title is always displayed on its own, and the version selector appears below it. The version selector displays Version n for every option in the select field, including the version of the page being viewed.

Because of this, we don't need the extra item that was prepended to the options, to display the currently selected component name and version.

@rsill-neo4j rsill-neo4j merged commit 2214871 into neo4j-documentation:master Jul 23, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants