Avoid autoscroll when changing tab in tabbed example. #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-docs-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
recrwplay
pushed a commit
to recrwplay/docs-ui
that referenced
this pull request
May 3, 2024
…ation#226) I think it's a bad UX if the page moves unexpectedly. When looking at examples, people may want to look at them together with the text leading to it, and they have to manually scroll back up to.
recrwplay
pushed a commit
that referenced
this pull request
Jun 3, 2024
I think it's a bad UX if the page moves unexpectedly. When looking at examples, people may want to look at them together with the text leading to it, and they have to manually scroll back up to.
recrwplay
pushed a commit
that referenced
this pull request
Jun 3, 2024
I think it's a bad UX if the page moves unexpectedly. When looking at examples, people may want to look at them together with the text leading to it, and they have to manually scroll back up to.
stefano-ottolenghi
added a commit
that referenced
this pull request
Jul 23, 2024
This reverts commit 1259ce4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's a bad UX if the page moves unexpectedly. When looking at examples, people may want to look at them together with the text leading to it, and they have to manually scroll back up to.
Before
After
Question for @adam-cowley and @recrwplay , if you remember from 4 years ago: why do we have both
[.tabs]and[.tabbed-example]?I believe we are actively only using
[.tabbed-example]. If that's the case, can I declutter and entirely remove the[.tabs]bit?