Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create labels from roles in docs #211

Merged
merged 15 commits into from
Mar 6, 2024
Merged

Create labels from roles in docs #211

merged 15 commits into from
Mar 6, 2024

Conversation

recrwplay
Copy link
Collaborator

Usage

[role=label--*]

Can be existing labels eg [role=label--enterprise-edition] or action-version labels such as [role=label--new-5.11] or [role=label--deprecated-5.13]

  • Roles in this format are converted to labels.
  • Roles applied to headings and table captions are displayed inline, right-aligned.
  • Roles on block level elements are displayed before the corresponding block element. Styles should be applied to make it clear that the label applies to the block. We might want to limit the block elements where these roles can be used.
  • Roles should not be used for inline elements, where the label:... inline macro can be used.

For action-version labels we should limit these to:

  • new
  • removed
  • deprecated

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for neo4j-docs-ui ready!

Name Link
🔨 Latest commit a3a1c34
🔍 Latest deploy log https://app.netlify.com/sites/neo4j-docs-ui/deploys/65e882fea5ed830008ba130d
😎 Deploy Preview https://deploy-preview-211--neo4j-docs-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@JPryce-Aklundh JPryce-Aklundh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, @recrwplay - thanks!

recrwplay and others added 12 commits March 5, 2024 18:42
The default style for `[bibliography]` sections includes bullet points and padding. This change removes both.
When an ID is set on a block that is part of a tabbed group the tab
switching and scroll happens as it does when a user clicks on a tab.
```
:page-banner: note
:page-banner-text: Lorem ipsum dolor sit est.
:page-banner-link: https://neo4j.com/docs
:page-banner-link-text: Link text
```

`note` is the default, `warning` can also be used.
@recrwplay recrwplay merged commit 4dcccc9 into master Mar 6, 2024
5 checks passed
@renetapopova renetapopova deleted the roles-everywhere branch March 7, 2024 09:56
@recrwplay recrwplay mentioned this pull request Mar 8, 2024
recrwplay added a commit that referenced this pull request Mar 8, 2024
Fixes a few issues in the initial implementation of #211:

- adds `cluster` and `dynamic` labels
- fixes padding in admonitions
recrwplay added a commit to recrwplay/docs-ui that referenced this pull request May 3, 2024
Usage

`[role=label--*]`

Can be existing labels eg `[role=label--enterprise-edition]` or
action-version labels such as `[role=label--new-5.11]` or
`[role=label--deprecated-5.13]`

- Roles are converted to labels.
- Roles applied to headings and table captions are displayed inline,
right-aligned.
- Roles on block level elements are displayed before the corresponding
block element.
recrwplay added a commit to recrwplay/docs-ui that referenced this pull request May 3, 2024
Fixes a few issues in the initial implementation of neo4j-documentation#211:

- adds `cluster` and `dynamic` labels
- fixes padding in admonitions
recrwplay added a commit that referenced this pull request Jun 3, 2024
Usage

`[role=label--*]`

Can be existing labels eg `[role=label--enterprise-edition]` or
action-version labels such as `[role=label--new-5.11]` or
`[role=label--deprecated-5.13]`

- Roles are converted to labels.
- Roles applied to headings and table captions are displayed inline,
right-aligned.
- Roles on block level elements are displayed before the corresponding
block element.
recrwplay added a commit that referenced this pull request Jun 3, 2024
Fixes a few issues in the initial implementation of #211:

- adds `cluster` and `dynamic` labels
- fixes padding in admonitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants