Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite cheat-sheet URLs to access page sections #196

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

recrwplay
Copy link
Collaborator

@recrwplay recrwplay commented Oct 11, 2023

This PR works in conjunction with updates to redirects for the Cypher cheat sheet so that a URL in the form /docs/cypher-cheat-sheet/current/match/ can be redirected to /docs/cypher-cheat-sheet/current/auradb-enterprise#match

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for neo4j-docs-ui ready!

Name Link
🔨 Latest commit d4b741d
🔍 Latest deploy log https://app.netlify.com/sites/neo4j-docs-ui/deploys/6526f8cba032040008d009a6
😎 Deploy Preview https://deploy-preview-196--neo4j-docs-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@recrwplay recrwplay changed the title Use URLparams to access page sections Rewrite cheat-sheet URLs to access page sections Oct 11, 2023
@recrwplay
Copy link
Collaborator Author

Latest commits handle any valid URL forms:

  • /docs/cypher-cheat-sheet/current/optional-match - valid because the sitemap will include /current/match/
  • - /docs/cypher-cheat-sheet/5/auradb-enterprise/optional-match - not a URL we claim to publish, but valid in the sense that we always force a product name into the path, and optional-match can be tested against IDs on the page. We also test for the form _optional_match because that will be the default ID generated by Antora. If there's no match, it is discarded.

@recrwplay recrwplay merged commit d4e437b into neo4j-documentation:master Oct 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant