Skip to content

Commit

Permalink
Fix version selector bugs (#255)
Browse files Browse the repository at this point in the history
Recent updates in the version selector, and previous changes that were
specific to the cheat sheet, meant the version of the cheat that is
being displayed was excluded from the version selector.

This PR fixes that and a bug in the code for defining the default
product to display.
  • Loading branch information
recrwplay committed Aug 22, 2024
1 parent 434225a commit 56a21a9
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 7 additions & 1 deletion src/js/50-cheat-sheet-toggle.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,14 @@ const prodMatrix = {

// get the default product from optionMap
const defaultProdArray = optionMap.find((prod) => prod.default === 'true')
const defaultProd = defaultProdArray ? defaultProdArray.value : optionMap[0].value

// display for 'all' products unless a differnt value is specified via attributes in source
let defaultProd
if (defaultProdArray && optionMap) {
defaultProd = defaultProdArray ? defaultProdArray.value : optionMap[0].value
} else {
defaultProd = 'all'
}
const defaultClasses = ['exampleblock', 'sect2', 'sect1']

document.addEventListener('DOMContentLoaded', function () {
Expand Down
2 changes: 1 addition & 1 deletion src/partials/nav-selectors.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

<select data-current="{{@root.page.version}}" class="version-selector dropdown-styles">
{{#each page.versions}}
{{#unless (or this.prerelease (and (eq this.version @root.page.version) (eq @root.page.attributes.theme 'cheat-sheet') ))}}
{{#unless this.prerelease}}
<option
data-version="{{this.displayVersion}}"
value="{{{relativize this.url}}}"
Expand Down

0 comments on commit 56a21a9

Please sign in to comment.