Refactor, harden, and bring up to date #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefano-ottolenghi
force-pushed
the
refactor
branch
from
9b4a865 to
a3c8984
Compare
This was referenced Nov 1, 2023
stefano-ottolenghi
added a commit
to neo4j-documentation/docs-ui
that referenced
this pull request
Nov 3, 2023
- widget moved to the left, and is part of the html output rather than being a floating js object. Because the right ToC has `position: sticky` and scrolls itself as you progress through a page, I was unable to leave the feedback on the right _and_ avoid it shadowing some content. I've made the nav on the left slightly smaller so people can't think there's anything underneath the feedback. It gets expanded to full height when the feedback vanishes. - after leaving feedback, politely thanks you and vanishes within a couple seconds - you _can't_ leave negative feedback without adding a message - you _can_ leave a message to a positive feedback (but may also leave it empty) - the user journey through docs pages is registered and submitted as part of their feedback - taken away the `Edit this page` links, and improved style/wording overall ---- Depends on neo4j-labs/neo4j-labs.github.io#3 neo4j-contrib/dx-feedback-form#2
stefano-ottolenghi
added a commit
to neo4j-labs/neo4j-labs.github.io
that referenced
this pull request
Nov 3, 2023
Surface new collected data, namely `information` on positive feedback, and the user journey. Depends on neo4j-contrib/dx-feedback-form#2 neo4j-documentation/docs-ui#197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apoc(they will be ignored)403HTTP responseDepends on
neo4j-labs/neo4j-labs.github.io#3
neo4j-documentation/docs-ui#197