This repository has been archived by the owner on Mar 11, 2019. It is now read-only.
msgpack: Improvements and fixes for the unpacker #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a constructor to 'Unpacked' to call 'msgpack_unpacked_init'. Let 'off' be 'null' by default in 'Unpacked.next'. Add 'buffer_consumed' to 'Unpacked' which has to be invoked once we write to 'buffer' with the number of bytes written. Make 'data' in 'Unpacker' return an unowned 'Object' since it is held by the unpacker.
|
Merged, thanks. Not sure about the test suite… i want to keep this repo lean for people who are using it as a submodule/subtree. |
|
I understand. I'll add it in the integration library instead and send improvements/fixes upstream. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the unpacker (streaming & non-streaming). I did not test them earlier.
I plan to write a small integration library to have convenient I/O streams upon that.
I wrote a small testsuite and if you're interested, I'll send another PR. It's really easy to write with Meson and it would be a good combination with #34.