Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add course authoring mfe s3 deployment action #1

Merged
merged 1 commit into from
May 10, 2024
Merged

feat: add course authoring mfe s3 deployment action #1

merged 1 commit into from
May 10, 2024

Conversation

johanseto
Copy link
Collaborator

@johanseto johanseto commented May 9, 2024 •
edited
Loading

Description

Add course-authoring deployment action to s3.

Repo vars already configured.

Stage deployment
image

@johanseto johanseto changed the base branch from open-release/palm.nelp to open-rc/palm.nelp May 9, 2024 20:43
@johanseto johanseto force-pushed the jlc/add-deploy-mfe-s3-action branch from 474e0d9 to 1d07a68 Compare May 9, 2024 20:43
@johanseto johanseto force-pushed the jlc/add-deploy-mfe-s3-action branch from 1d07a68 to 59e9da2 Compare May 9, 2024 20:45
@johanseto johanseto force-pushed the jlc/add-deploy-mfe-s3-action branch from 59e9da2 to 57e710e Compare May 9, 2024 20:56
@johanseto johanseto requested a review from andrey-canon May 9, 2024 21:37
@johanseto
Copy link
Collaborator Author

@andrey-canon The validate is not working but in upstream yes?
Do you now how to deal it?
https://github.com/nelc/frontend-app-course-authoring/actions/runs/9023433841/job/24795226067?pr=1
I think we need coverage token...
https://github.com/openedx/frontend-app-course-authoring/actions/runs/9019916822/workflow#L24

@johanseto
Copy link
Collaborator Author

@andrey-canon The validate is not working but in upstream yes? Do you now how to deal it? https://github.com/nelc/frontend-app-course-authoring/actions/runs/9023433841/job/24795226067?pr=1 I think we need coverage token... https://github.com/openedx/frontend-app-course-authoring/actions/runs/9019916822/workflow#L24

@andrey-canon or what do you think of #2

@johanseto johanseto force-pushed the jlc/add-deploy-mfe-s3-action branch from 57e710e to 3f128fd Compare May 10, 2024 20:31
@johanseto johanseto changed the title feat: add gradebook mfe s3 deployment action feat: add course authoring mfe s3 deployment action May 10, 2024
@johanseto johanseto merged commit 1e6cdb8 into open-rc/palm.nelp May 10, 2024
5 checks passed
andrey-canon pushed a commit that referenced this pull request Dec 17, 2024
@johanseto @andrey-canon
feat: course-authoring MFE s3 deployment action (#1)
931e3fd
andrey-canon pushed a commit that referenced this pull request Dec 17, 2024
@johanseto @andrey-canon
feat: course-authoring MFE s3 deployment action (#1)
ca40aa5
@andrey-canon andrey-canon mentioned this pull request Dec 17, 2024
Merged
andrey-canon pushed a commit that referenced this pull request Dec 18, 2024
@johanseto @andrey-canon
feat: course-authoring MFE s3 deployment action (#1)
dbd8426
andrey-canon added a commit that referenced this pull request Dec 18, 2024
@andrey-canon @johanseto
feat: course-authoring MFE s3 deployment action (#1) (#4)
e7fa13e 
Co-authored-by: Johan Seto Kaiba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-canon andrey-canon andrey-canon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanseto @andrey-canon