Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tart macOS vm's as job container #2434
base: master
Are you sure you want to change the base?
feat: tart macOS vm's as job container #2434
Changes from 12 commits
ec7f288
0be92a8
b751b59
e4d7c63
2941e25
6c9ee6b
2b1fefe
538618a
e18951c
5512718
22d5a80
ae8e5ca
175ea58
01897b9
ce5d63f
bb077bc
706746e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 651 in pkg/runner/run_context.go
Codecov / codecov/patch
pkg/runner/run_context.go#L651
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like
-self-hosted
, but withtart://
. I forget this variant has only been used in act_runner as of now, but looks better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This started as a copy of hostenvironment, but is now different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should
0o777
be added as a constant? Maybe FULL_RWX or FULL_PERMSThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that I'm smart, but no providing options in the
-P <label>=tart://test?...
query doesn't actually work so only defaults for nowCheck warning on line 14 in pkg/runner/run_context_other.go
Codecov / codecov/patch
pkg/runner/run_context_other.go#L12-L14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone thinks to run this mode on another OS, abort as tart is not available and some syscall part doesn't compile anyway.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm reusing the docker container names used by containers, so no prefix and so on