Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle default value for azure addon policy #2905

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

viniciusdc
Copy link
Contributor

Reference Issues or PRs

Previous ENH PR #2888 included a bug with the default variable value for the azure_addon_policy_enabled setting.

What does this implement/fix?

  • Fixes the default value attr. for the recent addition while also including the missing field as a configurable option in the nebari-config.yaml schema.

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

@viniciusdc viniciusdc added type: bug 🐛 Something isn't working provider: Azure labels Jan 10, 2025
@dcmcand dcmcand merged commit f394676 into main Jan 10, 2025
26 checks passed
@dcmcand dcmcand deleted the fix-azure-addon-policy-default branch January 10, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider: Azure type: bug 🐛 Something isn't working
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants