Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Use GitHub secrets instead of Vault #2889

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

smokestacklightnin
Copy link
Contributor

Reference Issues or PRs

Resolves #2835

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

@marcelovilla
Copy link
Member

Thanks @smokestacklightnin, this looks good!

We'll wait for @dcmcand to come back so we can add the secrets and test the workflows. I think the provider workflow won't run from a fork and the other three (aws, azure and gcp) will need to be triggered manually.

@smokestacklightnin
Copy link
Contributor Author

smokestacklightnin commented Jan 11, 2025

The AWS Deployment test failure shows a puzzling error (I included line numbers because it is a very long file):

222419   │ 2025-01-07T21:19:12.3277347Z 2025-01-07 21:19:12     ERROR  206 deployment_fixtures: Please specify `region` in the nebari-config.yaml or if initializing the nebari-config, set t
         │ he region via the `--region` flag or via the AWS_DEFAULT_REGION environment variable.
222420   │ 2025-01-07T21:19:12.3278318Z Traceback (most recent call last):
222421   │ 2025-01-07T21:19:12.3281269Z   File "/home/runner/work/nebari/nebari/tests/tests_integration/deployment_fixtures.py", line 204, in deploy
222422   │ 2025-01-07T21:19:12.3282066Z     _cleanup_nebari(config)
222423   │ 2025-01-07T21:19:12.3282927Z   File "/home/runner/work/nebari/nebari/tests/tests_integration/deployment_fixtures.py", line 101, in _cleanup_nebari
222424   │ 2025-01-07T21:19:12.3283757Z     aws_cleanup(config)
222425   │ 2025-01-07T21:19:12.3284696Z   File "/opt/hostedtoolcache/Python/3.11.11/x64/lib/python3.11/site-packages/_nebari/provider/cloud/amazon_web_services.py", line 1028, in aws_cleanup
222426   │ 2025-01-07T21:19:12.3285734Z     aws_delete_s3_bucket(s3_bucket_name, region)
222427   │ 2025-01-07T21:19:12.3286955Z   File "/opt/hostedtoolcache/Python/3.11.11/x64/lib/python3.11/site-packages/_nebari/provider/cloud/amazon_web_services.py", line 781, in aws_delete_s3_bucket
222428   │ 2025-01-07T21:19:12.3288162Z     aws_delete_s3_objects(bucket_name, endpoint, region)
222429   │ 2025-01-07T21:19:12.3289497Z   File "/opt/hostedtoolcache/Python/3.11.11/x64/lib/python3.11/site-packages/_nebari/provider/cloud/amazon_web_services.py", line 719, in aws_delete_s3_objects
222430   │ 2025-01-07T21:19:12.3290707Z     session = aws_session(region=region)
222431   │ 2025-01-07T21:19:12.3291441Z               ^^^^^^^^^^^^^^^^^^^^^^^^^^
222432   │ 2025-01-07T21:19:12.3292615Z   File "/opt/hostedtoolcache/Python/3.11.11/x64/lib/python3.11/site-packages/_nebari/provider/cloud/amazon_web_services.py", line 36, in aws_session
222433   │ 2025-01-07T21:19:12.3293739Z     raise ValueError(
222434   │ 2025-01-07T21:19:12.3294860Z ValueError: Please specify `region` in the nebari-config.yaml or if initializing the nebari-config, set the region via the `--region` flag or via the AWS_DEFAULT_REGION environment variable.

I'm not sure yet why the region isn't being recognized when the region is specified in at least one place.

CC: @marcelovilla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New 🚦
Development

Successfully merging this pull request may close these issues.

[ENH] - Use GitHub secrets instead of Vault
2 participants