-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TYP: fix typing error in hookspecs, refactor NebariStage #1974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fangchenli! I left a few comments that I think we should discuss a bit further.
@costrouc could you have a look at this PR? |
@viniciusdc will check |
This has some big refactorings in the Nebari Stage which needs to be retested now that we changed a bit the behavior for the default schema dumps -- I will follow up on this, next week |
@viniciusdc should we close this one or is there still value here? |
Hi @dcmcand, There is a lot of value here. This is good work that we will need to encompass sooner or later (related to that schema refactoring I was talking about recently). I was waiting on this due to the exposing default config values Adam was working on. My opinion on this would be to close, and we will incorporate and cite those changes in a follow up PR |
Reference Issues or PRs
xref #1800 ##1894
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?