Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JupyterLab 4.x and add jupyterlab-pioneer #101

Merged
merged 39 commits into from
Jan 9, 2024
Merged

Upgrade to JupyterLab 4.x and add jupyterlab-pioneer #101

merged 39 commits into from
Jan 9, 2024

Conversation

aktech
Copy link
Member

@aktech aktech commented Dec 5, 2023

Upgrade JupyterLab to 4.x adds jupyterlab_pioneer, support for the same is added here: nebari-dev/nebari#2127

Removes the following unsupported extensions:

  • retrolab
  • jupyter-videochat
  • jupyter-tensorboard
  • jupyterlab_nvdashboard

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@aktech aktech changed the title Upgrade to JupyterLab 4.x Upgrade to JupyterLab 4.x and add jupyterlab_pioneer Dec 5, 2023
@pavithraes pavithraes self-requested a review December 6, 2023 12:18
@aktech
Copy link
Member Author

aktech commented Dec 6, 2023

Added a recipe for release on conda-forge conda-forge/staged-recipes#24685, we can use conda when that gets merged.

@aktech aktech changed the title Upgrade to JupyterLab 4.x and add jupyterlab_pioneer Upgrade to JupyterLab 4.x and add jupyterlab-pioneer Dec 19, 2023
@aktech
Copy link
Member Author

aktech commented Dec 19, 2023

Added the conda version of jupyterlab-pioneer as the recipe has been merged in conda-forge: conda-forge/staged-recipes#24685

Copy link
Member

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Amit! This looks good to me. :)

I think we'll need to wait to merge this until we have jlab 4 support in jupyterlab-conda-store? That should be soon because I know we have an open PR. I'll approve but label the PR as blocked. Please feel free to update the status as you see fit.

@pavithraes pavithraes added the status: blocked ⛔️ Another task is blocking this item label Jan 4, 2024
@dcmcand dcmcand merged commit b1e9291 into main Jan 9, 2024
5 checks passed
@dcmcand dcmcand deleted the jlab4 branch January 9, 2024 19:04
@pavithraes pavithraes mentioned this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies 📦 status: blocked ⛔️ Another task is blocking this item type: enhancement 💅🏼 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants