Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rocket icon to tab #21

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Add rocket icon to tab #21

merged 4 commits into from
Oct 30, 2024

Conversation

nenb
Copy link
Collaborator

@nenb nenb commented Oct 29, 2024

Adds rocket icon to tab.

Reference Issues or PRs

#14

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Copy link
Contributor

Binder 👈 Launch a Binder on branch nebari-dev/jupyterlab-jhub-apps/add-missing-tabs-icon

@nenb nenb added the feature label Oct 29, 2024
@krassowski krassowski linked an issue Oct 29, 2024 that may be closed by this pull request
@krassowski
Copy link
Member

I guess snapshots will need updating

@nenb
Copy link
Collaborator Author

nenb commented Oct 29, 2024

bot please update snapshots

@nenb
Copy link
Collaborator Author

nenb commented Oct 29, 2024

@krassowski Don't merge yet as it appears that the snapshot for linux shows that the logo is not correctly positioned. I'm going to grab some lunch, and then fix this when I come back.

@nenb
Copy link
Collaborator Author

nenb commented Oct 29, 2024

bot please update snapshots

@nenb
Copy link
Collaborator Author

nenb commented Oct 29, 2024

This is now ready for review.

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@krassowski krassowski merged commit 7cd6071 into main Oct 30, 2024
@krassowski krassowski deleted the add-missing-tabs-icon branch October 30, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launch icon missing on tabs
2 participants