Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check Moodle 4.3, PHP 8.2, strict phpdoc #531

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

jrchamp
Copy link
Collaborator

@jrchamp jrchamp commented Oct 9, 2023

  • Add Moodle 4.3
  • Use PHP 8.2 for 4.3 and newer
  • Only run moodle-plugin-ci steps when the moodle-plugin-ci installs successfully
  • On moodle-plugin-ci v4, set --max-warnings 0 for phpdoc
  • If the job has been cancelled, mark the job as failed so that PR status checks cannot be bypassed
  • Use !cancelled() instead of always() as recommended by GitHub

From https://docs.github.com/en/actions/learn-github-actions/expressions#always

If you want to run a job or step regardless of its success or failure, use the recommended alternative: if: ${{ !cancelled() }}

@jrchamp jrchamp added the bug Fixes problems or reduces technical debt label Oct 9, 2023
@jrchamp jrchamp requested a review from a team October 9, 2023 21:32
@jrchamp jrchamp self-assigned this Oct 9, 2023
Copy link
Contributor

@smbader smbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Onward and upward!

@jrchamp jrchamp merged commit 32e35d3 into ncstate-delta:main Oct 12, 2023
7 checks passed
@jrchamp jrchamp deleted the ci/bump-versions branch October 12, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes problems or reduces technical debt
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants