Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove date and time display on course page for no fixed time meetings #529

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

karenliulll
Copy link
Contributor

Fixes #528

The enhancement of meeting date and time display on course page was introduced in #493, but no fixed time meetings actually don't need it since they are supposed to keep going without an end time, and it's redundant to show the start time.

@karenliulll karenliulll self-assigned this Oct 6, 2023
Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic makes sense! I added a couple suggestions that I hope are helpful. 😄

lib.php Outdated Show resolved Hide resolved
classes/dates.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let's get this merged.

@jrchamp jrchamp merged commit 3d02a35 into main Oct 12, 2023
12 checks passed
@jrchamp jrchamp deleted the fix/no-fixed-time-meeting-remove-time-info-display branch October 12, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Meeting with no set time
2 participants