Merge pull request #581 from haietza/iconfix

Fix for Large icon on sessions export page #579
ncstate-delta · Mar 28, 2024 · 0ad6b4c · 0ad6b4c
2 parents a6dddce + 5db97da
commit 0ad6b4c
Show file tree

Hide file tree

Showing 10 changed files with 15 additions and 8 deletions.
diff --git a/participants.php b/participants.php
@@ -166,7 +166,8 @@
         'export' => 'xls',
     ]);
     $xlsstring = get_string('application/vnd.ms-excel', 'mimetypes');
-    $xlsicon = html_writer::img($OUTPUT->image_url('f/spreadsheet'), $xlsstring, ['title' => $xlsstring]);
+    $xlsicon = html_writer::img($OUTPUT->image_url('f/spreadsheet'), $xlsstring,
+        ['title' => $xlsstring, 'class' => 'mimetypeicon']);
     echo get_string('export', 'mod_zoom') . ': ' . html_writer::link($exporturl, $xlsicon);
 
     echo $OUTPUT->footer();

diff --git a/styles.css b/styles.css
@@ -42,3 +42,8 @@
     border: none;
 }
 
+#page-mod-zoom-participants .mimetypeicon {
+    width: 24px;
+    height: 24px;
+}
+
diff --git a/tests/advanced_passcode_test.php b/tests/advanced_passcode_test.php
@@ -29,7 +29,7 @@
 /**
  * PHPunit testcase class.
  */
-class advanced_passcode_test extends basic_testcase {
+final class advanced_passcode_test extends basic_testcase {
     /**
      * Fake data from get_user_security_settings().
      * @var object

diff --git a/tests/error_handling_test.php b/tests/error_handling_test.php
@@ -29,7 +29,7 @@
 /**
  * PHPunit testcase class.
  */
-class error_handling_test extends basic_testcase {
+final class error_handling_test extends basic_testcase {
     /**
      * Exception for when the meeting isn't found on Zoom.
      * @var not_found_exception

diff --git a/tests/get_meeting_reports_test.php b/tests/get_meeting_reports_test.php
@@ -34,7 +34,7 @@
  * PHPunit testcase class.
  * @covers \mod_zoom\task\get_meeting_reports
  */
-class get_meeting_reports_test extends advanced_testcase {
+final class get_meeting_reports_test extends advanced_testcase {
     /**
      * Scheduled task object.
      * @var \mod_zoom\task\get_meeting_reports

diff --git a/tests/mod_zoom_grade_test.php b/tests/mod_zoom_grade_test.php
@@ -29,7 +29,7 @@
 /**
  * PHPunit testcase class.
  */
-class mod_zoom_grade_test extends advanced_testcase {
+final class mod_zoom_grade_test extends advanced_testcase {
     /**
      * @var \stdClass Course record.
      */

diff --git a/tests/mod_zoom_invitation_test.php b/tests/mod_zoom_invitation_test.php
@@ -34,7 +34,7 @@
  * PHPunit testcase class for invitations.
  * @covers \mod_zoom\invitation
  */
-class mod_zoom_invitation_test extends advanced_testcase {
+final class mod_zoom_invitation_test extends advanced_testcase {
     /**
      * Setup to ensure that fixtures are loaded.
      */

diff --git a/tests/mod_zoom_webservice_test.php b/tests/mod_zoom_webservice_test.php
@@ -30,7 +30,7 @@
  * PHPunit testcase class.
  * @covers \mod_zoom\webservice
  */
-class mod_zoom_webservice_test extends advanced_testcase {
+final class mod_zoom_webservice_test extends advanced_testcase {
     /**
      * @var object Anonymous class to mock \curl.
      */

diff --git a/tests/privacy/mod_zoom_provider_test.php b/tests/privacy/mod_zoom_provider_test.php
@@ -35,7 +35,7 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  * @coversDefaultClass \mod_zoom\privacy\provider
  */
-class mod_zoom_provider_test extends provider_testcase {
+final class mod_zoom_provider_test extends provider_testcase {
     /** @var object The zoom instance object. */
     protected $zoominstance;
 

diff --git a/view.php b/view.php
@@ -94,6 +94,7 @@
  * Get the display name for a Zoom user.
  * This is wrapped in a function to avoid unnecessary API calls.
  *
+ * @package mod_zoom
  * @param string $zoomuserid Zoom user ID.
  * @return ?string
  */