Added File.stream/.stream! to Traversal check #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great add - thanks for catching this and opening the PR, @jcowgar! |
|
There were a few others missing from the File traversal checks, I was unsure if I should add them all or not. For example, chgrp, rename, rm_rf!, and touch. Also was not sure if ls should be added. You can access the file system that way, but not alter it. Wasn't sure how paranoid the check should be. Let me know, I'd be happy to open another PR if desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stream functions were missing from the File traversal checks. This adds them. Checking for stream is as important as open.