Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ontology change request attribution and begin UJS replacement #344

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

jvendetti
Copy link
Member

This pull request resolves #323 by enhancing the attribution details in GitHub issues automatically generated from ontology change requests. If a user has provided their GitHub username and/or ORCID iD in their account settings, this information will now be included in the issue body for clear attribution.

The GitHub username is prefixed with an ‘@’ symbol in the issue body, triggering GitHub notifications for the user and drawing their attention to the issue through GitHub’s built-in notifications functionality.

Summary of additional changes:

  • Added a new ERB "footer" template for issue attribution, ensuring consistent presentation across different types of change requests
  • Transitioned some of the code for handling change requests from Rails UJS to Turbo Streams and Stimulus
  • Refactored the code in app/lib/kgcl/renderers to include a new base class that centralizes common methods
  • Fixed broken unit tests

@jvendetti
Copy link
Member Author

Screenshot of enhanced issue attribution and incorporation of GitHub mentions:

Screenshot 2024-11-08 at 11 00 51 AM

@jvendetti jvendetti self-assigned this Nov 8, 2024
@jvendetti jvendetti merged commit 156d1b8 into master Nov 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for GitHub handles/ORCID iDs in ontology change request issues
1 participant