Upgrade ontologies_api_client library #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent change to the find_by_acronym method in ontologies_api_client result in a lesser set of attributes returned from the triplestore. Also disable cache_refresh_all on updates.
Also refactor the update method to prevent an unnecessary fetch of all users and ontologies on successful updates.
Also disable cache_refresh_all on updates, and redirect to the user show page after successful creates. Redirecting to the (slow to load) ontology browse page isn't a good user experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request upgrades the ontologies_api_client library from 2.3.0 to 2.4.0 to address the issue raised in ncbo/bioportal-project#320. Along with this upgrade, the following changes are included:
OntologiesControllerto use theinclude: allparam where necessary. This resolves an issue where fewer attributes were returned from the triplestore due to a change in theontologies_api_client.findmethod with the more performantgetmethod in theProjectsControllerandUsersControllerUsersController#createmethod to redirect to the user show page upon successful account creation, avoiding the slow ontology browse page for a better user experienceProjectsController#updatemethod to prevent unnecessary fetching of all user and ontology objects after successfully updating a single projectSubmissionsController#newApplicationHelper#get_usernamemethod to avoid issuing REST calls for calculating a user's ID, reducing unnecessary requests