Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Fix classic view impurities #48

Closed
wants to merge 56 commits into from
Closed

Fix classic view impurities #48

wants to merge 56 commits into from

Conversation

epuzanov
Copy link
Contributor

This PR will fix 'Cassic UI: Impurities list is broken' issue.

Egor Puzanov and others added 30 commits January 29, 2021 16:19
add BaseSubstance Indexer
0eea5e4
enable BaseSubstanceIndexValueMaker in ginas.conf
339cd8a
docker development image for building custom GSRS extension
0cc9df0
@epuzanov
add forgotten comma
5fe1926
adding more javac build options
9a38aac
add support for extensions/patches
e43c5fc
add docker image building and running instructions to README.md file
c9132e2
@dkatzel-ncats
added _isClassification() for code for #32
5813297
fix truncate function in HTMLStringConverter
6c2ac89
add getStandardName function to Substance
9ba1b58
truncate refPname before saving
3b6687e
@dkatzel-ncats
updated molwitch-cdk with bug fixes for inchis and isotopes
521543e
Merge branch 'GSRS_DEV' into baseSubstanceIndexer
28e6644
add getters and setters for IndexValueMakerFactory.parameters and Bas…
1123fcb 
…eSubstanceIndexValueMaker.baseRelTypes attributes
use _nameHTML attribute for HTML name of related substance
b41e0c3
use _nameHTML attribute for creating of sysNames list
8b616d7
use stdName for searching related substance on substance editing form
e9ce438
stdName will be used as Page Title for Substance Detail page
6b4562c
fix NPE by Relationship.fixWhitespaceIssues if relationship type is null
d33c5ca
revert using Standard Name for substance details page title
9d72ee6
stdName will be used as Page Title for Substance Detail page
fd4834f
@dkatzel-ncats
updated molwitch-cdk with bug fixes for inchis and isotopes
0d64f10
@dkatzel-ncats
more molwitch updates especially for CDK and structure indexing
b949c34
@dkatzel-ncats
updated to latest molwitch api
6e31864
use a new gov.nih.ncats.structureIndexer module instead of old tripod…
b374f93 
….chem.indexer
fix conf/evolutions symbolic link creation
1345327
search JAVA_OPTS environment variable for config.file option in evolu…
68597c1 
…tion.sh if running without args
use XLINT environment variable to set -Xlint compilation option
aabc409
MOLWITCH build argument added to Dockerfile
57e860a
change StructureIndexer class in GinasApp controller
3654202
dkatzel-ncats and others added 23 commits June 3, 2021 17:13
@dkatzel-ncats
pulled out HTML String Converter Error Validation to its own Validato…
c537cca 
…r and made it be customizable to throw either warning or error (default to warnings)
add molwitch parameter to Docker devel build
19e8d66
do not hide non-public substances on mixture parents card
c433857
use setter for stdName property
fe4f58f
add SubstanceReferenceProcessor
037a875
add UpdateSubstanceReferenceTaskInitializer
4745eb6
fix StringIndexOutOfBoundsException in the truncate method of the HTM…
208f91b 
…LStringConverter class
use full name for names validation
8b537e4
fix typo in SubstanceFieldNameDecorator
a95efea
Merge branch 'molwitchUpdate' into GSRS_STAGE
159619c
Merge branch 'dockerExtensionsDev' into GSRS_STAGE
ddf070d
Merge branch 'fixHtmlNames' into GSRS_STAGE
32d9998
Merge branch 'fixHtmlTruncation' into GSRS_STAGE
0a83bde
Merge branch 'fixRelationshipNPE' into GSRS_STAGE
c4f4f23
Merge branch 'useStdNameSetter' into GSRS_STAGE
afa8e62
Merge branch 'doNotHideNonPublicMixture' into GSRS_STAGE
666ef94
Merge branch 'baseSubstanceIndexer' into GSRS_STAGE
30e79f1
Merge branch 'substanceReferenceUpdaterJob' into GSRS_STAGE
0fc5235
fix unclosed bracket in ginas.conf
25e7d61
Merge branch 'substanceReferenceUpdaterJob' into GSRS_STAGE
77bcbb7
set execution bit to evolutions.sh
78ecab9
Merge branch 'dockerExtensionsDev' into GSRS_STAGE
d3aa90b
fix classic view impurities
5d90980
@epuzanov epuzanov linked an issue Jul 23, 2021 that may be closed by this pull request
Cassic UI: Impurities list is broken #37
Open
@epuzanov epuzanov closed this Jul 23, 2021
@epuzanov
Copy link
Contributor Author

Wrong Base branch

@epuzanov epuzanov deleted the fixClassicViewImpurities branch July 23, 2021 14:57
@epuzanov epuzanov removed a link to an issue Jul 23, 2021
Cassic UI: Impurities list is broken #37
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tylerperyea tylerperyea Awaiting requested review from tylerperyea

@dkatzel-ncats dkatzel-ncats Awaiting requested review from dkatzel-ncats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epuzanov @dkatzel-ncats