Skip to content
This repository has been archived by the owner on Jul 16, 2022. It is now read-only.

updated panel to BS4 #226

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

updated panel to BS4 #226

wants to merge 2 commits into from

Conversation

gbjbaanb
Copy link

fixed #225 - changed to use bootstrap 4's card rather than the old panel class

@nazar-pc
Copy link
Owner

nazar-pc commented May 2, 2020

Why was z-index added in contrast to comment that is there explaining how it should be updated?

@gbjbaanb
Copy link
Author

gbjbaanb commented May 2, 2020

because the issue I raised mentioned it too. There are 2 commits, github seems to have associated them both with the same issue, I ahave no problem with that, fixes the original comment.

@nazar-pc
Copy link
Owner

nazar-pc commented May 2, 2020

Let's make setting that style with JS instead, otherwise with styles update you'll not be able to replicate the same CSS using provided instructions, it is really no for manual editing.

Also can't we use both classes to make it compatible with both bootstrap 3 and 4? I wouldn't want to bump major version of the library just because of this change.

@gbjbaanb
Copy link
Author

gbjbaanb commented May 2, 2020

Bootstrap 3 is EOL (3.3.7 release Jul 2016), and Bootstrap 5 will be available soon. So I guess it depends how many versions you want to support now. Personally, I'd put a bit of documentation in to say how to downgrade it for bootstrap3 if needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap update for v4
2 participants