refactor: mismatching of signature of base method #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Signature of
create()
method inRODetailEndpoint
does not match the one in parent classDetailEndpoint
.vs
Originally they matched each other, when
RODetailEndpoint
had been added (3862901 Dec '18). But later it was updated fromdef create(self, data)
todef create(self, data=None, api_version=None)
inDetailEndpoint
base class (12305bc Apr '22).This potentially leads to a violation of LSP.
Examples
Let's suppose user tries to call
create()
ofRODetailEndpoint
passingapi_version
.Expected behavior:
(user discovers he's trying to call not supported method)
Current behavior:
(user encounters on TypeError instead)
create()
inRODetailEndpoint
class, make it match the one inDetailEndpoint
base class