VSCode DevContainers bootstrapping cleanup #6688
Conversation
The CI tooling does enforce such a file regardless, but for a PR with no prior issue, you can use the PR number instead (so in this case, probably |
From [docs](https://code.visualstudio.com/docs/python/debugging): > You have "type" set to the deprecated value "python" in your launch.json file: replace "python" with "debugpy" instead to work with the Python Debugger extension.
This allows the debugger tasks to work out of the gate.
Instructions not necssary. Looks like this was fixed in nautobot#4906
msheiny
force-pushed
the
vscode_dev_containers_cleanup
branch
from
ba8cb59 to
67e9446
Compare
msheiny
force-pushed
the
vscode_dev_containers_cleanup
branch
from
67e9446 to
1d3bc91
Compare
okay, added to the latest revision 👍 |
| env_file_obj.write(f"PYTHON_VER={context.nautobot.python_ver}") | ||
|
|
||
| context.run(command, env={"PYTHON_VER": context.nautobot.python_ver}) |
There was a problem hiding this comment.
I'm curious - after #6659, do we need to also pass NAUTOBOT_VER to either of these calls, or is it not needed?
There was a problem hiding this comment.
Ahh this call is just running code nautobot.code-workspace to reopen the current session using the workspace file so I dont really think we need PYTHON_VER passed into that at all. It's not like it keeps that environment around in my VSCode session (it doesn't seem to be visible in my terminal session at least)
* Replace deprecated vscode task type From [docs](https://code.visualstudio.com/docs/python/debugging): > You have "type" set to the deprecated value "python" in your launch.json file: replace "python" with "debugpy" instead to work with the Python Debugger extension. * Under VSCode Devcontainer mode, start nautobot in debug This allows the debugger tasks to work out of the gate. * ARCH over-ride not necessary for VSCode containers Instructions not necessary. Looks like this was fixed in nautobot#4906 * Create env-file for VSCode dev container user * Include change fragment in PR --------- Co-authored-by: Michael Sheinberg <[email protected]> Co-authored-by: Glenn Matthews <[email protected]>
Closes: None
What's Changed
docker-compose.override.ymlto pass in the ARCH on Mac Silicon machines. This was fixed on theDockerfileitself using a global TARGETARCH variable at some point.invokelines to generate an.envdocker compose file for building. Not critical need but negates the need to keep this static default file up-to-date.typein the vscode workspace file frompython->debugpy(at some point they'll deprecate thepythontype completely according to their documentation. I just noticed VSCode was flagging it while I was inspecting the file.development/docker-compose.vscode-rdb.ymlfile to the DevContainer build file.TODO
Attached Screenshots, Payload ExampleN/AUnit, Integration TestsNot needed, purely dev environment changesExample App Updates (when adding/changing features)N/AOutline Remaining Work, Constraints from DesignN/A