Fixed incorrect copy button behavior on global search page. #6682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {% block javascript %} | ||
| {{ block.super }} | ||
| <script> | ||
| var clipboard = new ClipboardJS('.btn'); |
There was a problem hiding this comment.
Remind me, does this mean it applies to all btn classes on the page? If so, does it interfere with the operation of the Search or See All Results/Refine Search buttons on this page?
There was a problem hiding this comment.
It does not based on my manual testing. Also this block exists in object_list.html and it does not seem to interfere with any other buttons (Edit, Delete, etc) on that page either.
glennmatthews
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6678
What's Changed
Fixed incorrect copy button behavior on global search page.
Screenshots
N/A
Feel free to pull the change down and try it out.
TODO
- [ ] Attached Screenshots, Payload Example- [ ] Unit, Integration Tests- [ ] Documentation Updates (when adding/changing features)- [ ] Example App Updates (when adding/changing features)- [ ] Outline Remaining Work, Constraints from Design