Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LibreNMS Integration #636

Merged
merged 37 commits into from
Jan 14, 2025
Merged

Add LibreNMS Integration #636

merged 37 commits into from
Jan 14, 2025

Conversation

bile0026
Copy link
Contributor

@bile0026 bile0026 commented Dec 13, 2024 •
edited
Loading

Closes: # N/A

What's Changed

New SSoT Integration to sync the following information from LibreNMS:

  • Location
  • Device
  • Interface (future)
  • IPAddress (future)

Plan to add interface and IPAddress in another PR at a later date.

To Do

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@bile0026 bile0026 changed the title feat: ✨ start adding LibreNMS Integration with Locations and Devices sync Add LibreNMS Integration Dec 13, 2024
bile0026 and others added 22 commits December 13, 2024 13:30
@bile0026
refactor: 🔥 remove extra files
a6cd4e9
@bile0026
fix: 🐛 add check for tests
c81755e
@bile0026
fix: 🐛 fix load_type reference
143ca45
@bile0026
style: 🎨 formatting fixes
bad8734
@bile0026
style: 🎨 more reformatting
8af2122
@bile0026
chore: 🏗️ add change fragment
260e5db
@bile0026
docs: 📝 Add initial documentation for new integration
bc5b32e
@bile0026
docs: 📝 add librenms to menu
6ce00cc
@bile0026
feat: ✨ add flag to sync parent locations or not
5949b2f
@bile0026
docs: 📝 update docs
83888bb
@bile0026
fix: 🐛 fix location sync, remove geocode api for now
6a2cd6a
@bile0026
style: 🎨 fix formatting
73cb825
@bile0026
test: ✅ add librenms adapter tests
40b98df
@bile0026
fix: 🔥 remove geocode api
3818395
@bile0026
chore: 🎨 formatting fixes
f255eb3
@bile0026
test: ✅ add test for nautobot adapter
40eecb6
@bile0026
fix: 🎨 fix linting issues
18092c6
@bile0026
chore: ✅ fix adapter tests
fe0ed20
@bile0026
feat: ✨ add tenant filter for multiple librenms instance sync and dev…
3d399c1 
…ice id cf
@bile0026
fix: 🐛 fix tenant filtering
b100024
@bile0026
docs: 📝 update docs
7320b04
@bile0026
fix: 🐛 adjust tenant references
69a2733
@bile0026 bile0026 added the integration: librenms Issues/PRs for LibreNMS Integration label Dec 19, 2024
@bile0026 bile0026 marked this pull request as ready for review December 19, 2024 16:07
@bile0026 bile0026 requested a review from a team as a code owner December 19, 2024 16:07
@bile0026 bile0026 requested a review from jdrew82 December 19, 2024 16:07
@bile0026 bile0026 self-assigned this Dec 19, 2024
jdrew82
jdrew82 requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to discuss and address.

docs/user/integrations/librenms.md Outdated Show resolved Hide resolved
docs/user/integrations/librenms.md Show resolved Hide resolved
nautobot_ssot/integrations/librenms/diffsync/models/base.py Outdated Show resolved Hide resolved
nautobot_ssot/integrations/librenms/diffsync/models/nautobot.py Show resolved Hide resolved
nautobot_ssot/integrations/librenms/diffsync/adapters/librenms.py Outdated Show resolved Hide resolved
nautobot_ssot/integrations/librenms/diffsync/adapters/librenms.py Outdated Show resolved Hide resolved
@jdrew82
Copy link
Contributor

jdrew82 commented Jan 8, 2025

Also, it looks like we're missing the CODEOWNERS update for this integration.

jdrew82
jdrew82 requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to refactor to use mocks and patches for testing.

nautobot_ssot/integrations/librenms/diffsync/adapters/librenms.py Outdated Show resolved Hide resolved
@bile0026 bile0026 mentioned this pull request Jan 14, 2025
Closed
@jdrew82
Copy link
Contributor

jdrew82 commented Jan 14, 2025

CI currently failing due to nautobot/nautobot#6773.

jdrew82
jdrew82 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82
Copy link
Contributor

jdrew82 commented Jan 14, 2025

All tests have passed locally so I'm approving this and merging it. CI issue is in core code.

@jdrew82 jdrew82 merged commit 4476f07 into develop Jan 14, 2025
11 of 15 checks passed
@jdrew82 jdrew82 deleted the integration_librenms branch January 14, 2025 16:15
@jdrew82 jdrew82 mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrew82 jdrew82 jdrew82 approved these changes

Assignees

@bile0026 bile0026

Labels
integration: librenms Issues/PRs for LibreNMS Integration type: enhancement New feature or request type: major feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bile0026 @jdrew82