Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom relationship capabilities to the contrib module #271

Merged

Conversation

Kircheneer
Copy link
Contributor

No description provided.

@Kircheneer Kircheneer force-pushed the prototype-custom-relationships branch 3 times, most recently from 990299e to dc9ed4b Compare November 8, 2023 09:08
@mzbroch
Copy link
Contributor

mzbroch commented Nov 29, 2023

@Kircheneer How can we help to get this to the final line? We'd like to see this in, so we can remove dependency. Also we can help with testing.

@Kircheneer
Copy link
Contributor Author

@mzbroch I would appreicate testing in this case. Giving this a go in a real-world scenario would enhance my confidence it actually works.

@Renrut5
Copy link
Contributor

Renrut5 commented Dec 11, 2023

@Kircheneer I have been using this in a real world case and it's working fully outside of one thing: if the object doesn't yet exist in the database, it'll raise a warning %s matching query does not exist.

This seems to be happening on one to one relationships of the same object type, but it doesn't seem to impede functionality as the relationships are still created in the database.

@Kircheneer
Copy link
Contributor Author

Thanks @Renrut5 - I will try and push this forward then.

@Kircheneer Kircheneer force-pushed the prototype-custom-relationships branch 2 times, most recently from 2e93131 to a86facf Compare January 4, 2024 07:15
@Kircheneer
Copy link
Contributor Author

Added docs and fixed linting. Ready for review.

@Kircheneer Kircheneer marked this pull request as ready for review January 4, 2024 07:15
@Kircheneer Kircheneer requested a review from a team as a code owner January 4, 2024 07:15
@Kircheneer Kircheneer force-pushed the prototype-custom-relationships branch 2 times, most recently from 84005ef to 09b0e50 Compare January 4, 2024 07:17
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Kircheneer Kircheneer force-pushed the prototype-custom-relationships branch 2 times, most recently from 3bd6cf1 to c135041 Compare January 8, 2024 10:18
@Kircheneer Kircheneer force-pushed the prototype-custom-relationships branch from c135041 to 5f447bd Compare January 8, 2024 14:18
@Renrut5
Copy link
Contributor

Renrut5 commented Jan 8, 2024

@Kircheneer, just found a bug in it so don't merge yet. Did find a potential fix, but need to verify.

@Renrut5
Copy link
Contributor

Renrut5 commented Jan 9, 2024

@Kircheneer , it appears the issue was already addressed in your most recent commit. I have nothing to prevent merging at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants