-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom relationship capabilities to the contrib module #271
Add custom relationship capabilities to the contrib module #271
Conversation
990299e
to
dc9ed4b
Compare
@Kircheneer How can we help to get this to the final line? We'd like to see this in, so we can remove dependency. Also we can help with testing. |
@mzbroch I would appreicate testing in this case. Giving this a go in a real-world scenario would enhance my confidence it actually works. |
@Kircheneer I have been using this in a real world case and it's working fully outside of one thing: if the object doesn't yet exist in the database, it'll raise a warning This seems to be happening on one to one relationships of the same object type, but it doesn't seem to impede functionality as the relationships are still created in the database. |
Thanks @Renrut5 - I will try and push this forward then. |
2e93131
to
a86facf
Compare
Added docs and fixed linting. Ready for review. |
84005ef
to
09b0e50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3bd6cf1
to
c135041
Compare
c135041
to
5f447bd
Compare
@Kircheneer, just found a bug in it so don't merge yet. Did find a potential fix, but need to verify. |
@Kircheneer , it appears the issue was already addressed in your most recent commit. I have nothing to prevent merging at this time. |
No description provided.