Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U/smk4664 invoke updates #193

Merged
merged 3 commits into from
Dec 17, 2024
Merged

U/smk4664 invoke updates #193

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ca52a5
Support docker tags in `invoke unittest`
smk4664 Dec 16, 2024
8a4601d
Add Change Fragment
smk4664 Dec 16, 2024
81e9886
Update ValueError to use _get_docker_nautobot_version
smk4664 Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/190.housekeeping
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update the version parsing function to retrieve version using _get_docker_nautobot_version.
2 changes: 1 addition & 1 deletion tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def is_truthy(arg):


def _get_test_dump_path(context):
parsed_nautobot_version = context.nautobot_netbox_importer.nautobot_ver.split(".")
parsed_nautobot_version = _get_docker_nautobot_version(context).split(".")
if len(parsed_nautobot_version) < 2: # noqa: PLR2004
raise ValueError(f"Can't determine the Nautobot version from: {context.nautobot_netbox_importer.nautobot_ver}")
smk4664 marked this conversation as resolved.
Show resolved Hide resolved

Expand Down