Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes cost format in table view #258

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

qduk
Copy link
Contributor

@qduk qduk commented Dec 1, 2023

While working with a customer, two concerns came up about the format of some data in certian columns of the Contract list view. I figure I make a PR here to see if these would be welcome changes. If these are liked, I'll do the same for the 2.0 version.

This PR does two things:

  1. Comma separated cost in the "cost" column
  2. Reformats the date in the "Month-Day-Year` format.
    Screenshot 2023-11-30 at 4 00 31 PM

@progala
Copy link
Contributor

progala commented Jan 9, 2024

Thanks @qduk . I like the change to the cost format. As for the date, what is the rationale behind the change? Existing format is consistent across Nautobot and conforms to the ISO 8601 standard.

@qduk
Copy link
Contributor Author

qduk commented Jan 9, 2024

Thanks @qduk . I like the change to the cost format. As for the date, what is the rationale behind the change? Existing format is consistent across Nautobot and conforms to the ISO 8601 standard.

I think that was just my own bias creeping in. It definitely makes sense to leave it as is. I can remove that part from the PR.

@qduk
Copy link
Contributor Author

qduk commented Jan 9, 2024

@progala Removed Date formatting.

Copy link
Contributor

@progala progala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@progala progala changed the title Changes Date format and cost format in table view Changes cost format in table view Mar 20, 2024
@bradh11 bradh11 merged commit 1ca12f5 into nautobot:ltm-1.6 Apr 9, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants