Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and updates for Contract model #248

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Fixes and updates for Contract model #248

merged 1 commit into from
Jan 9, 2024

Conversation

progala
Copy link
Contributor

@progala progala commented Nov 3, 2023 •
edited
Loading

  • Fixes issue with number field not showing up in UI and API.
  • Fixes model validation to match UI validation. This ensures provider and contract_type fields are set.
  • Adds missing tests.

Addresses #242

@progala progala requested a review from jvanderaa as a code owner November 3, 2023 10:44
@progala progala requested a review from bradh11 November 3, 2023 11:00
@bradh11
Copy link
Contributor

bradh11 commented Nov 7, 2023

@progala I believe this addresses #242

@progala
Copy link
Contributor Author

progala commented Nov 7, 2023

@progala I believe this addresses #242

Yes, #242 will be fixed by this PR.

@progala progala linked an issue Nov 7, 2023 that may be closed by this pull request
Add Contract Number to contract view (list and detailed) #242
Closed
@bradh11 bradh11 merged commit c4c42e8 into ltm-1.6 Jan 9, 2024
40 checks passed
@bradh11 bradh11 deleted the contract-fixes branch January 9, 2024 15:26
@bradh11 bradh11 mentioned this pull request Jan 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

@bradh11 bradh11 Awaiting requested review from bradh11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Contract Number to contract view (list and detailed)
2 participants
@progala @bradh11