Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix invoke ruff always exiting with zero status #43

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix invoke ruff always exiting with zero status #43

merged 1 commit into from
Sep 13, 2024

Conversation

gsnider2195
Copy link
Contributor

nautobot/cookiecutter-nautobot-app#160

(nautobot-dev-example-py3.12) $ INVOKE_NAUTOBOT_DEV_EXAMPLE_LOCAL=true invoke ruff; echo $?
Would reformat: nautobot_dev_example/forms.py
1 file would be reformatted, 25 files already formatted
nautobot_dev_example/forms.py:20:14: F541 [*] f-string without any placeholders
Found 1 error.
[*] 1 fixable with the `--fix` option.
1


(nautobot-dev-example-py3.12) $ INVOKE_NAUTOBOT_DEV_EXAMPLE_LOCAL=true invoke ruff; echo $?
26 files already formatted
All checks passed!
0

@gsnider2195 gsnider2195 requested a review from a team as a code owner September 3, 2024 22:33
smk4664
smk4664 reviewed Sep 4, 2024
View reviewed changes
tasks.py Show resolved Hide resolved
@smk4664 smk4664 merged commit 8f21e73 into develop Sep 13, 2024
14 of 15 checks passed
@smk4664 smk4664 deleted the u/gas-160-invoke-ruff branch September 13, 2024 16:51
@gsnider2195 gsnider2195 mentioned this pull request Sep 13, 2024
Closed
gsnider2195 added a commit to nautobot/cookiecutter-nautobot-app that referenced this pull request Sep 23, 2024
@gsnider2195
backport nautobot/nautobot-app-dev-example#43
04dbff3
gsnider2195 added a commit to nautobot/cookiecutter-nautobot-app that referenced this pull request Sep 25, 2024
@gsnider2195
backport nautobot/nautobot-app-dev-example#43 (#173)
584e388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews left review comments

@smk4664 smk4664 smk4664 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsnider2195 @glennmatthews @smk4664