Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie updated by NetworkToCode Cookie Drift Manager Tool #324

Closed
wants to merge 1 commit into from
Closed

Cookie updated by NetworkToCode Cookie Drift Manager Tool #324

wants to merge 1 commit into from

Conversation

nautobot-bot
Copy link
Contributor

Template:

{
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "dir": "nautobot-app",
    "ref": "refs/tags/nautobot-app-v2.3.1",
    "path": null
}

Cookie:

{
    "remote": "https://github.com/nautobot/nautobot-app-chatops.git",
    "path": "/tmp/tmpw0l_410n/nautobot-app-chatops",
    "repository_path": "/tmp/tmpw0l_410n/nautobot-app-chatops",
    "dir": "",
    "branch_prefix": "drift-manager",
    "context": {
        "codeowner_github_usernames": "@glennmatthews @jvanderaa @smk4664 @whitej6",
        "full_name": "Network to Code, LLC",
        "email": "[email protected]",
        "github_org": "nautobot",
        "app_name": "nautobot_chatops",
        "verbose_name": "Nautobot ChatOps App",
        "app_slug": "nautobot-chatops",
        "project_slug": "nautobot-app-chatops",
        "repo_url": "https://github.com/nautobot/nautobot-app-chatops",
        "base_url": "chatops",
        "min_nautobot_version": "2.0.0",
        "max_nautobot_version": "2.9999",
        "camel_name": "NautobotChatOpsApp",
        "project_short_description": "Nautobot ChatOps App",
        "model_class_name": "None",
        "open_source_license": "Apache-2.0",
        "docs_base_url": "https://docs.nautobot.com",
        "docs_app_url": "https://docs.nautobot.com/projects/chatops/en/latest",
        "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
        "_output_dir": "/tmp/tmpw0l_410n",
        "_repo_dir": "/github/home/.cookiecutters/cookiecutter-nautobot-app/nautobot-app",
        "_checkout": "refs/tags/nautobot-app-v2.3.1"
    },
    "base_branch": "develop",
    "remote_name": "origin",
    "pull_request_strategy": "PullRequestStrategy.CREATE",
    "post_actions": [
        "PostAction.BLACK"
    ],
    "baked_commit_ref": "76744d296d468b03fb528c902f68c3dc230a9a3f",
    "draft": true
}

CLI Arguments:

{
    "cookie_dir": "",
    "input": false,
    "json_filename": "",
    "output_dir": "",
    "push": true,
    "template": "",
    "template_dir": "",
    "template_ref": "refs/tags/nautobot-app-v2.3.1",
    "pull_request": null,
    "post_action": [],
    "disable_post_actions": false,
    "draft": null
}

Cookie updated by NetworkToCode Cookie Drift Manager Tool
8746d4a 
Template:

```
{
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "dir": "nautobot-app",
    "ref": "refs/tags/nautobot-app-v2.3.1",
    "path": null
}
```

Cookie:

```
{
    "remote": "https://github.com/nautobot/nautobot-app-chatops.git",
    "path": "/tmp/tmpw0l_410n/nautobot-app-chatops",
    "repository_path": "/tmp/tmpw0l_410n/nautobot-app-chatops",
    "dir": "",
    "branch_prefix": "drift-manager",
    "context": {
        "codeowner_github_usernames": "@glennmatthews @jvanderaa @smk4664 @whitej6",
        "full_name": "Network to Code, LLC",
        "email": "[email protected]",
        "github_org": "nautobot",
        "app_name": "nautobot_chatops",
        "verbose_name": "Nautobot ChatOps App",
        "app_slug": "nautobot-chatops",
        "project_slug": "nautobot-app-chatops",
        "repo_url": "https://github.com/nautobot/nautobot-app-chatops",
        "base_url": "chatops",
        "min_nautobot_version": "2.0.0",
        "max_nautobot_version": "2.9999",
        "camel_name": "NautobotChatOpsApp",
        "project_short_description": "Nautobot ChatOps App",
        "model_class_name": "None",
        "open_source_license": "Apache-2.0",
        "docs_base_url": "https://docs.nautobot.com",
        "docs_app_url": "https://docs.nautobot.com/projects/chatops/en/latest",
        "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
        "_output_dir": "/tmp/tmpw0l_410n",
        "_repo_dir": "/github/home/.cookiecutters/cookiecutter-nautobot-app/nautobot-app",
        "_checkout": "refs/tags/nautobot-app-v2.3.1"
    },
    "base_branch": "develop",
    "remote_name": "origin",
    "pull_request_strategy": "PullRequestStrategy.CREATE",
    "post_actions": [
        "PostAction.BLACK"
    ],
    "baked_commit_ref": "76744d296d468b03fb528c902f68c3dc230a9a3f",
    "draft": true
}
```

CLI Arguments:

```
{
    "cookie_dir": "",
    "input": false,
    "json_filename": "",
    "output_dir": "",
    "push": true,
    "template": "",
    "template_dir": "",
    "template_ref": "refs/tags/nautobot-app-v2.3.1",
    "pull_request": null,
    "post_action": [],
    "disable_post_actions": false,
    "draft": null
}
```
smk4664
smk4664 reviewed Aug 27, 2024
View reviewed changes
pyproject.toml
@@ -80,21 +67,13 @@ Markdown = "*"
# Render custom markdown for version added/changed/remove notes
markdown-version-annotations = "1.0.1"
# Rendering docs to HTML
mkdocs = "1.5.2"
mkdocs-include-markdown-plugin = "6.0.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still want to get this one into the cookie, I think it is a useful plugin to have.

smk4664
smk4664 reviewed Aug 27, 2024
View reviewed changes
pyproject.toml
@@ -201,26 +180,27 @@ target-version = "py38"
select = [
"D", # pydocstyle
"F", "E", "W", # flake8
"PL", # pylint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this didn't make it into the 2.3.1 release.

smk4664
smk4664 reviewed Aug 27, 2024
View reviewed changes
tasks.py
@@ -838,51 +904,3 @@ def validate_app_config(context):
file="development/app_config_schema.py",
env={"APP_CONFIG_SCHEMA_COMMAND": "validate"},
)


# ------------------------------------------------------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

@smk4664
Copy link
Contributor

smk4664 commented Aug 27, 2024

I have fixes ready, but I am unable to build as this requires Nautobot-capacity-metrics to release a python 3.12 compatible version.

@smk4664
Copy link
Contributor

smk4664 commented Aug 29, 2024

Closing as we are baking with a newer version.

@smk4664 smk4664 closed this Aug 29, 2024
@smk4664 smk4664 deleted the drift-manager/pr branch August 29, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smk4664 smk4664 smk4664 left review comments

@glennmatthews glennmatthews Awaiting requested review from glennmatthews glennmatthews will be requested when the pull request is marked ready for review glennmatthews is a code owner

@romanukes romanukes Awaiting requested review from romanukes romanukes will be requested when the pull request is marked ready for review romanukes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nautobot-bot @smk4664