-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debugs to ms teams. Fix Aristacv errors. #293
Conversation
@zackt25 I'd recommend splitting into two PRs. Debug as one PR and a separate PR for renaming. For the renaming there's a lot more work that would be needed and to do it properly consistent branding the rename would need to a major release as it would change how to configure ChatOps for cloud vision. |
The renaming piece is complicated. The original name of the command was "Cloudvision". When combined in the integration, we tried to rename it to Arista CloudVision to match the SSOT. But due to the way that the commands are picked up by the workers, the folder name must match the command. With what is in place, the Cloudvision plugin tries to load, even if you have cloudvision disabled. nautobot-app-chatops/nautobot_chatops/integrations/utils.py Lines 12 to 16 in 5a4f354
Is the problematic line that uses the folder name. |
MS Teams files doesn't really have any debug messages for helping troubleshoot so I added some.
I also fixed a integration issue with Aristacv and cloudvision.