Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debugs to ms teams. Fix Aristacv errors. #293

Merged
merged 9 commits into from
Mar 28, 2024
Merged

Conversation

zackt25
Copy link
Contributor

@zackt25 zackt25 commented Dec 20, 2023

MS Teams files doesn't really have any debug messages for helping troubleshoot so I added some.

I also fixed a integration issue with Aristacv and cloudvision.

@whitej6
Copy link
Contributor

whitej6 commented Dec 21, 2023

@zackt25 I'd recommend splitting into two PRs. Debug as one PR and a separate PR for renaming. For the renaming there's a lot more work that would be needed and to do it properly consistent branding the rename would need to a major release as it would change how to configure ChatOps for cloud vision.

@smk4664
Copy link
Contributor

smk4664 commented Dec 31, 2023

@zackt25 I'd recommend splitting into two PRs. Debug as one PR and a separate PR for renaming. For the renaming there's a lot more work that would be needed and to do it properly consistent branding the rename would need to a major release as it would change how to configure ChatOps for cloud vision.

The renaming piece is complicated. The original name of the command was "Cloudvision". When combined in the integration, we tried to rename it to Arista CloudVision to match the SSOT. But due to the way that the commands are picked up by the workers, the folder name must match the command. With what is in place, the Cloudvision plugin tries to load, even if you have cloudvision disabled.

def _each_integration() -> Generator[str, None, None]:
"""Return all integrations."""
for path in Path(__file__).parent.iterdir():
if (path / "worker.py").is_file():
yield path.name

Is the problematic line that uses the folder name.

@smk4664 smk4664 merged commit 533627a into develop Mar 28, 2024
16 checks passed
@smk4664 smk4664 mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants