Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace natsContext with standard NATS Options #204

Closed
wants to merge 3 commits into from
Closed

Replace natsContext with standard NATS Options #204

wants to merge 3 commits into from

Conversation

samuelattwood
Copy link
Member

No description provided.

@samuelattwood samuelattwood requested a review from caleblloyd June 13, 2024 12:45
@caleblloyd
Copy link
Contributor

caleblloyd commented Jun 13, 2024 •
edited
Loading

I don't know if this is going to work... The Hash of the NATS Context only hashed strings and file contents. Since a file could be reloaded on disk but not actually have any changes, this would result in a consistent hash.

Lots of this data is discarded or in pointers once in natsOpts. For example - TLS Config - I don't think there is a good way to hash that within natsOpts. Hashing pointers results in a different hash every time a file is reloaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleblloyd caleblloyd Awaiting requested review from caleblloyd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuelattwood @caleblloyd