Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing natsOpts from service observations and js advisories #203

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Allow passing natsOpts from service observations and js advisories #203

merged 2 commits into from
Jun 12, 2024

Conversation

caleblloyd
Copy link
Contributor

@caleblloyd caleblloyd commented Jun 12, 2024 •
edited
Loading

Allow programmatically passing NATS Opts when using Service Observations and JS Advisories

@caleblloyd caleblloyd requested a review from samuelattwood June 12, 2024 20:19
samuelattwood
samuelattwood approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@samuelattwood samuelattwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelattwood samuelattwood merged commit 91df8f4 into main Jun 12, 2024
2 checks passed
@samuelattwood samuelattwood deleted the adv-obs-nats-opts branch June 12, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelattwood samuelattwood samuelattwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caleblloyd @samuelattwood