Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Shapes Drawn With PaintingStyle.stroke to Register Hits Within Bounds #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Yey007
Copy link

@Yey007 Yey007 commented Jul 24, 2023

Resolves #11... for the most part. There were a few shapes where I didn't really know what to do, like Path, Arc, and Line, since they're not always closed. The rest of the shapes, however, now let you specify whether you want to register hits within bounds even if that area is transparent. Let me know what you think!

@nateshmbhat
Copy link
Owner

Hi , thanks for your work. It's been some time since I worked on this. can you explain what is this bounds problem ur talking about with an example or something if possible ?

@Yey007
Copy link
Author

Yey007 commented Aug 25, 2024

Hi. To be honest, I moved away from Flutter for my use case. However, the original problem I was trying to solve was with closed shapes. Say you have a closed shape like a circle. If it's a circle that isn't filled in (with just the boundary of the circle drawn), HitTest currently does not register hits if the user clicks in that transparent region inside the circle but not on the boundary. This PR allows that behavior to be configured.

Looks like there are also some extra files committed in this PR that I didn't notice. If you're interested in this feature let me know and I'll try to clean things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make HitTest method configurable
2 participants